== Series Details == Series: series starting with [CI,1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41586/ State : warning == Summary == $ dim checkpatch origin/drm-tip e95c3b723634 drm/i915: Move a bunch of workaround-related code to its own file -:745: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #745: new file mode 100644 -:818: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #818: FILE: drivers/gpu/drm/i915/intel_workarounds.c:69: +#define WA_REG(addr, mask, val) do { \ + const int r = wa_add(dev_priv, (addr), (mask), (val)); \ + if (r) \ + return r; \ + } while (0) -:824: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #824: FILE: drivers/gpu/drm/i915/intel_workarounds.c:75: +#define WA_SET_BIT_MASKED(addr, mask) \ + WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask)) -:827: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #827: FILE: drivers/gpu/drm/i915/intel_workarounds.c:78: +#define WA_CLR_BIT_MASKED(addr, mask) \ + WA_REG(addr, (mask), _MASKED_BIT_DISABLE(mask)) -:830: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #830: FILE: drivers/gpu/drm/i915/intel_workarounds.c:81: +#define WA_SET_FIELD_MASKED(addr, mask, value) \ + WA_REG(addr, (mask), _MASKED_FIELD(mask, value)) total: 0 errors, 2 warnings, 3 checks, 1383 lines checked 8780063884cc drm/i915: Split out functions for different kinds of workarounds _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
