== Series Details == Series: drm/i915: Implement proper fallback training for MST URL : https://patchwork.freedesktop.org/series/41576/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79ee10fad03d drm/atomic: Print debug message on atomic check failure 1806094a081c drm/i915: Move DP modeset retry work into intel_dp -:30: WARNING:BAD_SIGN_OFF: Duplicate signature #30: Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx> total: 0 errors, 1 warnings, 0 checks, 80 lines checked cb4d253765c8 drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() -:81: WARNING:LONG_LINE: line over 100 characters #81: FILE: include/drm/drm_dp_mst_helper.h:627: +struct drm_dp_mst_topology_state *drm_atomic_dp_mst_get_topology_state(struct drm_atomic_state *state, -:82: WARNING:LONG_LINE: line over 100 characters #82: FILE: include/drm/drm_dp_mst_helper.h:628: + struct drm_dp_mst_topology_mgr *mgr); total: 0 errors, 2 warnings, 0 checks, 54 lines checked 680fffc380ff drm/dp_mst: Remove all evil duplicate state pointers 159c47b20396 drm/dp_mst: Make drm_dp_mst_topology_state subclassable -:82: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #82: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c:504: + ret = drm_dp_mst_topology_mgr_init( -:213: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #213: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:3183: +void +__drm_atomic_dp_mst_destroy_topology_state(struct drm_dp_mst_topology_state *state) { -:336: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #336: FILE: drivers/gpu/drm/nouveau/nv50_display.c:3464: + if (!(state = kzalloc(sizeof(*state), GFP_KERNEL))) { total: 2 errors, 0 warnings, 1 checks, 347 lines checked a263f4d4b36f drm/dp_mst: Add reset_state callback to topology mgr -:32: CHECK:LINE_SPACING: Please don't use multiple blank lines #32: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2104: + + total: 0 errors, 0 warnings, 1 checks, 38 lines checked 2bf5c7d2ca86 drm/i915: Only use one link bw config for MST topologies -:54: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #54: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:60: + mst_state = to_intel_dp_mst_topology_state( -:116: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #116: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:564: + __drm_atomic_dp_mst_duplicate_topology_state( -:198: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #198: FILE: drivers/gpu/drm/i915/intel_drv.h:1002: +#define to_intel_dp_mst_topology_state(x) container_of(x, struct intel_dp_mst_topology_state, base); total: 0 errors, 1 warnings, 2 checks, 152 lines checked 9ce56af682cb drm/i915: Make intel_dp_mst_atomic_check() idempotent -:96: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #96: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:118: + * state */ -:99: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #99: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:121: + ret = intel_dp_mst_atomic_release_vcpi_slots( -:144: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #144: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:167: + return intel_dp_mst_atomic_release_vcpi_slots( total: 0 errors, 1 warnings, 2 checks, 111 lines checked bcf603212a59 drm/dp_mst: Add MST fallback retraining helpers -:202: WARNING:TYPO_SPELLING: 'occuring' may be misspelled - perhaps 'occurring'? #202: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2207: + * prevent new modesets from occuring on the topology without first requiring -:424: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #424: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2429: + crtc_state = drm_atomic_get_new_crtc_state( -:474: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #474: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2479: + ret = drm_atomic_dp_mst_retrain_connector( -:494: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #494: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2499: + * retrain something that no longer exists */ total: 0 errors, 2 warnings, 2 checks, 533 lines checked 0c71910b3b40 drm/i915: Implement proper fallback training for MST -:40: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'? #40: So: move retraining into it's own seperate handler. Running in a -:41: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'? #41: seperate handler allows us to avoid stalling the ESI during link -:66: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #66: FILE: drivers/gpu/drm/i915/intel_ddi.c:3067: + ret = intel_dp_handle_train_failure( -:169: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #169: FILE: drivers/gpu/drm/i915/intel_dp.c:4275: + if (wait_for_completion_timeout( -:251: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 28) #251: FILE: drivers/gpu/drm/i915/intel_dp.c:4350: + if (!*need_retrain) { + *need_retrain = intel_dp_mst_needs_retrain( -:252: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #252: FILE: drivers/gpu/drm/i915/intel_dp.c:4351: + *need_retrain = intel_dp_mst_needs_retrain( -:359: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #359: FILE: drivers/gpu/drm/i915/intel_dp.c:4448: + intel_set_cpu_fifo_underrun_reporting( -:368: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #368: FILE: drivers/gpu/drm/i915/intel_dp.c:4452: + intel_set_pch_fifo_underrun_reporting( -:391: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #391: FILE: drivers/gpu/drm/i915/intel_dp.c:4473: + * reporting */ -:393: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #393: FILE: drivers/gpu/drm/i915/intel_dp.c:4475: + intel_set_cpu_fifo_underrun_reporting( -:397: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #397: FILE: drivers/gpu/drm/i915/intel_dp.c:4479: + intel_set_pch_fifo_underrun_reporting( -:431: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #431: FILE: drivers/gpu/drm/i915/intel_dp.c:4507: + if (intel_dp_get_link_train_fallback_values( -:448: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #448: FILE: drivers/gpu/drm/i915/intel_dp.c:4554: + ret = intel_dp_handle_train_failure( -:522: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #522: FILE: drivers/gpu/drm/i915/intel_dp.c:6430: + drm_dp_mst_topology_mgr_lower_link_rate( -:531: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #531: FILE: drivers/gpu/drm/i915/intel_dp.c:6439: + drm_mode_connector_set_link_status_property( -:611: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #611: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:164: + ret = drm_dp_atomic_mst_check_retrain( -:616: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #616: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:169: + mst_state = drm_atomic_dp_mst_get_topology_state( -:618: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #618: FILE: drivers/gpu/drm/i915/intel_dp_mst.c:171: + intel_mst_state = to_intel_dp_mst_topology_state( total: 0 errors, 4 warnings, 14 checks, 575 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
