== Series Details == Series: selftests/i915_gem_gtt: Create igt_ggtt_scratch subtest URL : https://patchwork.freedesktop.org/series/41529/ State : warning == Summary == $ dim checkpatch origin/drm-tip e5d6592bb290 selftests/i915_gem_gtt: Create igt_ggtt_scratch subtest -:50: ERROR:CODE_INDENT: code indent should use tabs where possible #50: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1656: + ^Imutex_lock(&i915->drm.struct_mutex);$ -:50: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #50: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1656: + ^Imutex_lock(&i915->drm.struct_mutex);$ -:50: WARNING:LEADING_SPACE: please, no spaces at the start of a line #50: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1656: + ^Imutex_lock(&i915->drm.struct_mutex);$ -:54: WARNING:BRACES: braces {} are not necessary for single statement blocks #54: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1660: + if (!order) { + err = -ENOMEM; + } -:65: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #65: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1671: + drm_mm_for_each_hole(node, &ggtt->base.mm, hole_start, hole_end) { + -:91: ERROR:OPEN_BRACE: that open brace { should be on the previous line #91: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1697: + for ( n = 0; n <= 2; n++) + { -:91: ERROR:SPACING: space prohibited after that open parenthesis '(' #91: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1697: + for ( n = 0; n <= 2; n++) -:101: ERROR:OPEN_BRACE: that open brace { should be on the previous line #101: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1707: + for ( n = 0; n <= 2; n++) + { -:101: ERROR:SPACING: space prohibited after that open parenthesis '(' #101: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1707: + for ( n = 0; n <= 2; n++) -:108: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n != 1' #108: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1714: + if ((n != 1) && (val != 2)) { -:108: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'val != 2' #108: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1714: + if ((n != 1) && (val != 2)) { -:121: WARNING:LONG_LINE: line over 100 characters #121: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1727: + ggtt->base.clear_range(&ggtt->base, tmp[order[m]].start, tmp[order[m]].size); -:124: ERROR:OPEN_BRACE: that open brace { should be on the previous line #124: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1730: + for ( n = 0; n <= 2; n++) + { -:124: ERROR:SPACING: space prohibited after that open parenthesis '(' #124: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1730: + for ( n = 0; n <= 2; n++) -:139: WARNING:BRACES: braces {} are not necessary for single statement blocks #139: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1745: + for (m = 0; m < COUNT; m++) { + drm_mm_remove_node(&tmp[m]); + } -:152: WARNING:TABSTOP: Statements should start on a tabstop #152: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1758: + return err; -:165: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 8 errors, 6 warnings, 3 checks, 146 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
