Re: [PATCH igt 2/2] igt/gem_eio: Drop DRM_MASTER so we can reacquire it in the subtests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 05/04/2018 19:47, Chris Wilson wrote:
As we reopen the fd for each subtest, and we need a DRM_MASTER, we need
to drop master on the original before we are allowed to claim DRM_MASTER
on the second.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
---
  tests/gem_eio.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 9599e73d..66d8c18a 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -41,6 +41,7 @@
  #include <drm.h>
#include "igt.h"
+#include "igt_device.h"
  #include "igt_sysfs.h"
  #include "sw_sync.h"
@@ -674,6 +675,7 @@ igt_main igt_fixture {
  		fd = drm_open_driver(DRIVER_INTEL);
+		igt_device_drop_master(fd);


Is it master by default? I can't spot a place which would set master either in igt/lib/ or in drm.

But in any case, should we have gem_reopen_driver attempt to drop master before re-opening? And if it was successful, drop it again after re-opening to end up in the same state?

Regards,

Tvrtko

igt_require(i915_reset_control(true));
  		igt_force_gpu_reset(fd);


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux