Hi Abhay, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.16 next-20180405] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Abhay-Kumar/drm-i915-set-minimum-CD-clock-to-twice-the-BCLK/20180406-143913 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-x001-201813 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/gpu//drm/i915/intel_audio.c: In function 'i915_audio_component_codec_wake_override': >> drivers/gpu//drm/i915/intel_audio.c:742:21: error: unused variable 'min_cdclk' [-Werror=unused-variable] int current_cdclk, min_cdclk; ^~~~~~~~~ cc1: all warnings being treated as errors vim +/min_cdclk +742 drivers/gpu//drm/i915/intel_audio.c 736 737 static void i915_audio_component_codec_wake_override(struct device *kdev, 738 bool enable) 739 { 740 struct drm_i915_private *dev_priv = kdev_to_i915(kdev); 741 u32 tmp; > 742 int current_cdclk, min_cdclk; 743 744 if (!IS_GEN9_BC(dev_priv)) 745 return; 746 747 current_cdclk = i915_audio_component_get_cdclk_freq(kdev); 748 749 /* 750 * Before probing for HDA Codec we need to make sure 751 * "The CD clock frequency must be at least twice 752 * the frequency of the Azalia BCLK." 753 */ 754 if (INTEL_GEN(dev_priv) >= 9 && current_cdclk <= 192000) { 755 intel_cdclk_bump(dev_priv); 756 } 757 758 i915_audio_component_get_power(kdev); 759 760 /* 761 * Enable/disable generating the codec wake signal, overriding the 762 * internal logic to generate the codec wake to controller. 763 */ 764 tmp = I915_READ(HSW_AUD_CHICKENBIT); 765 tmp &= ~SKL_AUD_CODEC_WAKE_SIGNAL; 766 I915_WRITE(HSW_AUD_CHICKENBIT, tmp); 767 usleep_range(1000, 1500); 768 769 if (enable) { 770 tmp = I915_READ(HSW_AUD_CHICKENBIT); 771 tmp |= SKL_AUD_CODEC_WAKE_SIGNAL; 772 I915_WRITE(HSW_AUD_CHICKENBIT, tmp); 773 usleep_range(1000, 1500); 774 } 775 776 i915_audio_component_put_power(kdev); 777 } 778 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
