== Series Details == Series: Add support for GuC-based SLPC (rev12) URL : https://patchwork.freedesktop.org/series/2691/ State : warning == Summary == $ dim checkpatch origin/drm-tip d53e35c3815d drm/i915/guc/slpc: Add SLPC control to enable_guc modparam 6cf8c81b2bca drm/i915/guc/slpc: Disable host RPS bb01d5961927 drm/i915/guc/slpc: Lay out SLPC init/enable/disable/fini helpers -:106: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #106: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 126 lines checked bd7f17539b74 drm/i915/guc/slpc: Enable SLPC in GuC load control params 1ed1936a7f0d drm/i915/guc/slpc: Add SLPC communication interfaces -:61: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 219 lines checked b4db20e94cee drm/i915/guc/slpc: Allocate/initialize/release SLPC shared data -:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #64: FILE: drivers/gpu/drm/i915/i915_drv.h:2419: +#define IS_ULX_SKU(dev_priv) (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) -:65: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #65: FILE: drivers/gpu/drm/i915/i915_drv.h:2420: +#define IS_ULT_SKU(dev_priv) (IS_SKL_ULT(dev_priv) || \ + IS_KBL_ULT(dev_priv) || \ + IS_CFL_ULT(dev_priv)) total: 0 errors, 0 warnings, 2 checks, 240 lines checked b470c3d03b1c drm/i915/guc/slpc: Send RESET event to restart/enable SLPC tasks -:80: ERROR:SPACING: space required before the open parenthesis '(' #80: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:170: + switch(status) { total: 1 errors, 0 warnings, 0 checks, 253 lines checked 423af87658f2 drm/i915/guc/slpc: Send SHUTDOWN event to stop SLPC tasks 6b80339da56f drm/i915/guc/slpc: Reset SLPC on engine reset with flag TDR_OCCURRED 182447860555 drm/i915/guc/slpc: Add parameter set/unset/get, task control/status functions 8a14dde3f5d4 drm/i915/guc/slpc: Add support for sysfs min/max frequency control b1b7f3a4a9a0 drm/i915/guc/slpc: Add enable/disable controls for SLPC tasks 1683b3cafee8 drm/i915/debugfs: Create generic string tokenize function and update CRC control parsing 9f4c9bd0a832 drm/i915/guc/slpc: Add debugfs support to read/write/revert the parameters -:75: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #75: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2807: + seq_printf(m, "%s=%u, override=%s\n", + slpc_params_desc[slpc->debug.param_id], -:116: CHECK:BRACES: braces {} should be used on all arms of this statement #116: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2848: + if (!strcmp(words[0], "read")) [...] + else if (!strcmp(words[0], "write")) [...] + else if (!strcmp(words[0], "revert")) [...] + else { [...] -:122: CHECK:BRACES: Unbalanced braces around else statement #122: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2854: + else { -:137: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #137: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2869: + return (n_words-1); ^ -:141: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #141: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2873: +static ssize_t slpc_param_ctl_write(struct file *file, const char __user *ubuf, + size_t len, loff_t *offp) -:282: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'id >= SLPC_PARAM_TASK_ENABLE_GTPERF' #282: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:634: + if ((id >= SLPC_PARAM_TASK_ENABLE_GTPERF) && + (id <= SLPC_PARAM_TASK_DISABLE_DCC)) { -:282: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'id <= SLPC_PARAM_TASK_DISABLE_DCC' #282: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:634: + if ((id >= SLPC_PARAM_TASK_ENABLE_GTPERF) && + (id <= SLPC_PARAM_TASK_DISABLE_DCC)) { total: 0 errors, 0 warnings, 7 checks, 332 lines checked 18faa445aae6 drm/i915/guc/slpc: Add i915_guc_slpc_info to debugfs -:245: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #245: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:656: + intel_gpu_freq(dev_priv, + task_data->max_unslice_freq * GEN9_FREQ_SCALER)); -:248: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #248: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:659: + intel_gpu_freq(dev_priv, + task_data->min_unslice_freq * GEN9_FREQ_SCALER)); -:251: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #251: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:662: + intel_gpu_freq(dev_priv, + task_data->max_slice_freq * GEN9_FREQ_SCALER)); -:254: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #254: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:665: + intel_gpu_freq(dev_priv, + task_data->min_slice_freq * GEN9_FREQ_SCALER)); -:271: CHECK:LINE_SPACING: Please don't use multiple blank lines #271: FILE: drivers/gpu/drm/i915/intel_guc_slpc.c:682: + + total: 0 errors, 0 warnings, 5 checks, 229 lines checked 0029128b8efc drm/i915/guc/slpc: Add SLPC banner to RPS debugfs interfaces 73cfdac309a0 HAX: drm/i915/guc: Enable GuC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
