|
On 28/03/18 19:29, Tvrtko Ursulin
wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio register access. This patch rewrites it to use only PMU. Only overall command streamer busyness and GPU global data such as power and frequencies are included in this new version. For access to more GPU functional unit level data, an OA metric based tool like gpu-top should be used instead. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> Cc: Petri Latvala <petri.latvala@xxxxxxxxx> Looks good to me too. Sorry, this isn't a detailed review, but since it's a lot safer : Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> |
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
