✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: optimize perf stream usage on Gen7.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915/perf: optimize perf stream usage on Gen7.5
URL   : https://patchwork.freedesktop.org/series/40656/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9b2b2bce30f9 drm/i915/perf: pass stream to enable metric set vfuncs
2c159dc9b427 drm/i915/perf: check the value of PROP_SAMPLE_OA uapi parameter
f8c532a11bbb drm/i915/perf: simplify OA unit enabling on gen7
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d79651522e89 ("drm/i915: Enable i915 perf stream for Haswell OA unit")'
#6: 
In commit d79651522e89c "drm/i915: Enable i915 perf stream for Haswell

total: 1 errors, 0 warnings, 0 checks, 46 lines checked
291babe97961 drm/i915/perf: do not warn when OA buffer is already allocated
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8: 
will see that OA buffer has already been allocated, while a previous process

total: 0 errors, 1 warnings, 0 checks, 18 lines checked
7cffe8920f46 drm/i915/perf: remove empty line
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 28964cf25ee6 ("drm/i915/perf: disable NOA logic when not used")'
#6: 
This was added by mistake in commit 28964cf25e "drm/i915/perf: disable NOA

total: 1 errors, 0 warnings, 0 checks, 7 lines checked
802d6c8c391c drm/i915: rename PPGTT/GGTT fields OA registers
-:51: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#51: FILE: drivers/gpu/drm/i915/i915_reg.h:539:
+#define  GEN8_OABUFFER_MEM_SELECT_GGTT      (1<<0)  /* 0: PPGTT, 1: GGTT */
                                               ^

-:61: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#61: FILE: drivers/gpu/drm/i915/i915_reg.h:549:
+#define  GEN7_OASTATUS2_MEM_SELECT_GGTT     (1<<0) /* 0: PPGTT, 1: GGTT */
                                               ^

total: 0 errors, 0 warnings, 2 checks, 49 lines checked
a98cf44da1ba drm/i915/perf: pass stream as argument to oa enable vfunc
b5e465c044d7 drm/i915/perf: add more debug message on open perf open & configs
29add79e1f33 drm/i915/perf: allowing opening the perf stream without sampling
3f72a99726b8 drm/i915/perf: limit OA buffer size to minimum when unread
9115b82ed959 drm/i915/perf: remove redundant oa buffer initialization
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
gen[78]_oa_enable), so we don't need to initialize when preparing the metric

-:58: CHECK:LINE_SPACING: Please don't use multiple blank lines
#58: FILE: drivers/gpu/drm/i915/i915_perf.c:2066:
 
+

total: 0 errors, 1 warnings, 1 checks, 54 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux