Re: [PATCH 1/2] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jani Nikula (2018-03-21 14:07:54)
> Fix the last two direct ->gen usages.
> 
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a504281e2afa..af538c4a3aeb 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -119,7 +119,7 @@ void intel_device_info_dump(const struct intel_device_info *info,
>                    INTEL_DEVID(dev_priv),
>                    INTEL_REVID(dev_priv),
>                    intel_platform_name(info->platform),
> -                  info->gen);
> +                  INTEL_GEN(dev_priv));

This is wrong, this should be from the local intel_device_info *info.
(Passed in from the caller, so dev_priv is very wrong here, and yes the
INTEL_foo() above are on my hit list :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux