On Mon, Mar 19, 2018 at 11:24:17PM -0700, Lucas De Marchi wrote: > This will allow the struct to be embedded in intel_shared_dpll. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 7 ------- > drivers/gpu/drm/i915/intel_dpll_mgr.h | 10 ++++++++++ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 51c5ae4e9116..52d6e731c3e9 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -1877,13 +1877,6 @@ static void intel_ddi_pll_init(struct drm_device *dev) > } > } > > -struct dpll_info { > - const char *name; > - const int id; > - const struct intel_shared_dpll_funcs *funcs; > - uint32_t flags; > -}; > - > struct intel_dpll_mgr { > const struct dpll_info *dpll_info; > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h b/drivers/gpu/drm/i915/intel_dpll_mgr.h > index f24ccf443d25..e99d6385478a 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.h > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.h > @@ -205,6 +205,16 @@ struct intel_shared_dpll_funcs { > struct intel_dpll_hw_state *hw_state); > }; > > +/** > + * struct dpll_info - display PLL platform specific info > + */ > +struct dpll_info { > + const char *name; > + const int id; The const here seems pointless. Well, I guess if we go with the copy then it might not be. Although then we get to wonder why 'flags' isn't const. > + const struct intel_shared_dpll_funcs *funcs; > + uint32_t flags; This structure seems to be poorly organized for 64bit machines. > +}; > + > /** > * struct intel_shared_dpll - display PLL with tracked state and users > */ > -- > 2.14.3 -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx