Quoting Matthew Auld (2018-03-19 18:08:54) > GEM_WARN_ON() was originally intended to be used only as: > > if (GEM_WARN_ON(expr)) > ... > > but it just so happens to also work as simply: > > GEM_WARN_ON(expr); > > since it just wraps WARN_ON, which is a little misleading since for > !DRM_I915_DEBUG_GEM builds the second case will actually break the > build. Given that there are some patches floating around which seem to > miss this, it probably makes sense to just make it work for both cases. That really was quite intentional. The only time to use GEM_WARN_ON() is inside an if, otherwise what's the point? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
