On Sat, 17 Mar 2018, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote: > == Series Details == > > Series: cgroup private data and DRM/i915 integration > URL : https://patchwork.freedesktop.org/series/40142/ > State : warning > > == Summary == Matt, please do look into these, I think most of these are valid. Thanks, Jani. > > $ dim checkpatch origin/drm-tip > ed1f8853712d cgroup: Allow registration and lookup of cgroup private data (v2) > -:52: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment > #52: FILE: include/linux/cgroup-defs.h:436: > + spinlock_t privdata_lock; > > -:276: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct kref *' should also have an identifier name > #276: FILE: kernel/cgroup/cgroup.c:6095: > + void (*free)(struct kref *); > > total: 0 errors, 1 warnings, 1 checks, 238 lines checked > a2cf2e58be10 cgroup: Introduce task_get_dfl_cgroup() (v2) > 7837b0190516 cgroup: Introduce cgroup_priv_get_current > cd9b81bd5505 drm/i915: Adjust internal priority definitions > d4e5c99d4496 drm/i915: cgroup integration (v3) > -:34: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? > #34: > new file mode 100644 > > -:109: WARNING:SIZEOF_PARENTHESIS: sizeof *priv should be sizeof(*priv) > #109: FILE: drivers/gpu/drm/i915/i915_cgroup.c:71: > + priv = kzalloc(sizeof *priv, GFP_KERNEL); > > -:207: WARNING:LONG_LINE: line over 100 characters > #207: FILE: drivers/gpu/drm/i915/i915_drv.c:2843: > + DRM_IOCTL_DEF_DRV(I915_CGROUP_SETPARAM, i915_cgroup_setparam_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW), > > -:207: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV) > #207: FILE: drivers/gpu/drm/i915/i915_drv.c:2843: > + DRM_IOCTL_DEF_DRV(I915_CGROUP_SETPARAM, i915_cgroup_setparam_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW), > ^ > > -:221: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment > #221: FILE: drivers/gpu/drm/i915/i915_drv.h:1743: > + struct mutex cgroup_lock; > > -:242: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations > #242: FILE: drivers/gpu/drm/i915/i915_drv.h:2697: > +} > +static inline void i915_cgroup_shutdown(struct drm_i915_private *dev_priv) {} > > -:270: WARNING:LONG_LINE: line over 100 characters > #270: FILE: include/uapi/drm/i915_drm.h:381: > +#define DRM_IOCTL_I915_CGROUP_SETPARAM DRM_IOW(DRM_COMMAND_BASE + DRM_I915_CGROUP_SETPARAM, struct drm_i915_cgroup_param) > > total: 0 errors, 4 warnings, 3 checks, 239 lines checked > 6d7ce25f32de drm/i915: Introduce 'priority offset' for GPU contexts (v3) > -:121: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'def' - possible side-effects? > #121: FILE: drivers/gpu/drm/i915/i915_cgroup.c:172: > +#define CGROUP_GET(name, field, def) \ > +int i915_cgroup_get_current_##name(struct drm_i915_private *dev_priv) \ > +{ \ > + struct kref *ref; \ > + int val = def; \ > + if (!dev_priv->cgroup_priv_key) return def; \ > + ref = cgroup_priv_get_current(dev_priv->cgroup_priv_key); \ > + if (ref) { \ > + val = cgrp_ref_to_i915(ref)->field; \ > + kref_put(ref, i915_cgroup_free); \ > + } \ > + return val; \ > +} > > -:126: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line > #126: FILE: drivers/gpu/drm/i915/i915_cgroup.c:177: > + if (!dev_priv->cgroup_priv_key) return def; \ > > total: 1 errors, 0 warnings, 1 checks, 169 lines checked > dac3bdd93cb9 drm/i915: Introduce per-cgroup display boost setting > -:83: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations > #83: FILE: drivers/gpu/drm/i915/i915_drv.h:2706: > } > +static inline int > > total: 0 errors, 0 warnings, 1 checks, 89 lines checked > fa175d947839 drm/i915: Add context priority & priority offset to debugfs (v2) > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
