Op 12-03-18 om 15:23 schreef Ville Syrjälä: > On Mon, Mar 12, 2018 at 12:03:17PM +0100, Maarten Lankhorst wrote: >> Op 09-03-18 om 22:45 schreef Radhakrishna Sripada: >>> From: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> >>> >>> Rework the rotate and reflect subtests by checking the >>> crtc supported properties against the ones that the >>> test is testing. Remove the hardcoded platform names in >>> igt_require() >>> >>> v2: Make use of the property enums to get the supported rotations >>> >>> Cc: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx> >>> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx> >>> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >>> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >>> Cc: Mika Kahola <mika.kahola@xxxxxxxxx> >>> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx> >>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> >>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx> >>> --- >>> lib/igt_kms.h | 1 + >>> tests/kms_rotation_crc.c | 46 +++++++++++++++++++++++++++++++++++++--------- >>> 2 files changed, 38 insertions(+), 9 deletions(-) >> Just let it rest, it's not worth the effort to remove this, you only end up with more complicated code.. >> Closest I've come is below. Which will still fail because it will try to generate the wrong tilings pre-gen9.. > The current code is actually wrong. chv doesn't require X-tiling for > reflection. > > I think the actual hardware restrictions we have are: > gen4+: 0/180 degree rotation supported always > chv: supports reflection, except with 180 degree rotation > gen9+: 90/270 degree rotation supported with y/yf tiling > gen10+: supports reflection, except with linear fb So can we leave it the way it is now? ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
