Quoting Mika Kuoppala (2018-03-02 11:50:32) > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > > +static void i915_engines_set_mode(struct drm_i915_private *dev_priv, > > + unsigned engine_mask, > > + u32 mode) > > +{ > > + struct intel_engine_cs *engine; > > + enum intel_engine_id id; > > + > > + if (INTEL_GEN(dev_priv) < 3) > > + return; > > + > > + for_each_engine_masked(engine, dev_priv, engine_mask, id) > > + I915_WRITE_FW(RING_MI_MODE(engine->mmio_base), mode); > > Is there reason to not use gen3_stop_engine in this level? It clears HEAD/TAIL, so undoing it in the case of no reset is a bit more tricky. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx