On Wed, Feb 28, 2018 at 12:26 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Andy Lutomirski (2018-02-24 00:07:23) >> On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: >> > From: Andy Lutomirski <luto@xxxxxxxxxx> >> > >> > + >> > + dev_priv->psr.activate_timer.expires = jiffies - 1; >> >> That can't possibly be okay. > > As an initialisation value, set to the previous jiffie? You can set it > to the current jiffie, but then you have the issue of not noticing the > update to the current jiffie. > > So how is this any more incorrect? I don't think you can just write to fields in struct timer_list like that. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx