On Tue, Feb 27, 2018 at 08:52:49PM +0200, Jani Nikula wrote: > On Tue, 27 Feb 2018, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@xxxxxxxxx> wrote: > > On Tue, 2018-02-27 at 12:59 +0200, Jani Nikula wrote: > >> Localize link rate arrays by moving them to the functions where they're > >> used. > > > > I feel this array expresses platform capability concisely and it's easy > > to quickly check what rates a platform supports when the array is at the > > top. But,that's probably just me. > > I could argue both ways myself, hence RFC. :) > > BR, > Jani. > I prefer the localized array of these per platform rates since its better if this information is abstracted from the user and user only sees an array source_rates[]. Per platform rates will still be part of separate arrays for debug purposes and to check them within code, but since the rest of the driver only uses source_rates, sink_rates, common_rates arrays, having these per platform arrays local to the function make more sense. Regards Manasi > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
