Re: [PATCH v2] drm/i915: Disable SAGV on pre plane update.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rodrigo,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180223]
[cannot apply to v4.16-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-Disable-SAGV-on-pre-plane-update/20180226-094030
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x003-02260939 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/intel_display.c: In function 'intel_post_plane_update':
>> drivers/gpu//drm/i915/intel_display.c:5094:27: error: unused variable 'dev_priv' [-Werror=unused-variable]
     struct drm_i915_private *dev_priv = to_i915(dev);
                              ^~~~~~~~
   cc1: all warnings being treated as errors

vim +/dev_priv +5094 drivers/gpu//drm/i915/intel_display.c

  5089	
  5090	static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
  5091	{
  5092		struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
  5093		struct drm_device *dev = crtc->base.dev;
> 5094		struct drm_i915_private *dev_priv = to_i915(dev);
  5095		struct drm_atomic_state *old_state = old_crtc_state->base.state;
  5096		struct intel_crtc_state *pipe_config =
  5097			intel_atomic_get_new_crtc_state(to_intel_atomic_state(old_state),
  5098							crtc);
  5099		struct drm_plane *primary = crtc->base.primary;
  5100		struct drm_plane_state *old_pri_state =
  5101			drm_atomic_get_existing_plane_state(old_state, primary);
  5102	
  5103		intel_frontbuffer_flip(to_i915(crtc->base.dev), pipe_config->fb_bits);
  5104	
  5105		if (pipe_config->update_wm_post && pipe_config->base.active)
  5106			intel_update_watermarks(crtc);
  5107	
  5108		if (hsw_post_update_enable_ips(old_crtc_state, pipe_config))
  5109			hsw_enable_ips(pipe_config);
  5110	
  5111		if (old_pri_state) {
  5112			struct intel_plane_state *primary_state =
  5113				intel_atomic_get_new_plane_state(to_intel_atomic_state(old_state),
  5114								 to_intel_plane(primary));
  5115			struct intel_plane_state *old_primary_state =
  5116				to_intel_plane_state(old_pri_state);
  5117	
  5118			intel_fbc_post_update(crtc);
  5119	
  5120			if (primary_state->base.visible &&
  5121			    (needs_modeset(&pipe_config->base) ||
  5122			     !old_primary_state->base.visible))
  5123				intel_post_enable_primary(&crtc->base, pipe_config);
  5124		}
  5125	}
  5126	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux