>-----Original Message----- >From: Ville Syrjala [mailto:ville.syrjala@xxxxxxxxxxxxxxx] >Sent: Friday, February 23, 2018 3:12 AM >To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; Mihail Atanassov ><mihail.atanassov@xxxxxxx>; Liviu Dudau <liviu.dudau@xxxxxxx>; Brian >Starkey <brian.starkey@xxxxxxx>; Mali DP Maintainers ><malidp@xxxxxxxxxxxx>; Lin, Johnson <johnson.lin@xxxxxxxxx>; Shankar, Uma ><uma.shankar@xxxxxxxxx>; Sharma, Shashank <shashank.sharma@xxxxxxxxx> >Subject: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude >representation > >From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > >The documentation for the ctm matrix suggests a two's complement format, but >at least the i915 implementation is using sign-magnitude instead. And looks like >malidp is doing the same. Change the docs to match the current implementation, >and change the type from __s64 to __u64 to drive the point home. > Looks ok to me. Reviewed-by: Uma Shankar <uma.shankar@xxxxxxxxx> >Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx >Cc: Mihail Atanassov <mihail.atanassov@xxxxxxx> >Cc: Liviu Dudau <liviu.dudau@xxxxxxx> >Cc: Brian Starkey <brian.starkey@xxxxxxx> >Cc: Mali DP Maintainers <malidp@xxxxxxxxxxxx> >Cc: Johnson Lin <johnson.lin@xxxxxxxxx> >Cc: Uma Shankar <uma.shankar@xxxxxxxxx> >Cc: Shashank Sharma <shashank.sharma@xxxxxxxxx> >Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >--- > include/uapi/drm/drm_mode.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >index 2c575794fb52..b5d7d9e0eff5 100644 >--- a/include/uapi/drm/drm_mode.h >+++ b/include/uapi/drm/drm_mode.h >@@ -598,8 +598,11 @@ struct drm_mode_crtc_lut { }; > > struct drm_color_ctm { >- /* Conversion matrix in S31.32 format. */ >- __s64 matrix[9]; >+ /* >+ * Conversion matrix in S31.32 sign-magnitude >+ * (not two's complement!) format. >+ */ >+ __u64 matrix[9]; > }; > > struct drm_color_lut { >-- >2.16.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
