Re: [PATCH] drm/i915/execlists: Remove the ring advancement under preemption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Michel Thierry (2018-02-21 17:25:54)
> On 21/02/18 05:32, Chris Wilson wrote:
> > Load an empty ringbuffer for preemption, ignoring the lite-restore
> > workaround as we know the preempt context is always idle before preemption.
> > 
> 
> True, injecting the preempt context shouldn't cause a lite-restore.
> And the restriction was to always have Head!=Tail when attempting lite 
> restore.
> 
> > Note that after some digging by Michal Winiarski, we found that
> > RING_HEAD is no longer being updated (due to inhibiting context save
> > restore) so this patch is already in effect!
> > 
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Michal Winiarski <michal.winiarski@xxxxxxxxx>
> > Cc: Michel Thierry <michel.thierry@xxxxxxxxx>
> > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
> 
> Reviewed-by: Michel Thierry <michel.thierry@xxxxxxxxx>

And pushed. Thanks for the review, at worst this just shows that we have
an issue more readily :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux