How much do I want this uABI to rot away? Say "Never again!" to implicit aliasing. In the meantime, we do not need to perform duplicate work on bsd2 machines, as especially we do not know which engine bsd relates to. v2: When in doubt, shout! Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> --- lib/ioctl_wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 8748cfcf..b9b86079 100644 --- a/lib/ioctl_wrappers.c +++ b/lib/ioctl_wrappers.c @@ -1460,7 +1460,7 @@ bool gem_has_ring(int fd, unsigned ring) /* silly ABI, the kernel thinks everyone who has BSD also has BSD2 */ if ((ring & ~(3<<13)) == I915_EXEC_BSD) { - if (ring & (3 << 13) && !gem_has_bsd2(fd)) + if (!(ring & (3 << 13)) ^ !gem_has_bsd2(fd)) return false; } -- 2.16.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx