On Tue, Feb 20, 2018 at 10:46:45AM +0800, Mustamin B Mustaffa wrote:
> Currently, BXT_PP is hardcoded with value '0'.
> It practically disabled eDP backlight on MRB (BXT) platform.
>
> This patch will tell which BXT_PP registers (there are two set of PP_CONTROL in the spec)
> to be used as defined in VBT (Video Bios Timing table) and this will enabled eDP
> backlight controller on MRB (BXT) platform.
>
> v2:
> - Remove unnecessary information in commit message.
what was unnecessary? Do you have any Bugzilla entry or Fixes tag?
> - Assign vbt.backlight.controller to a backlight_controller variable and return
> the variable value.
> v3:
> - Rebased to latest code base.
> - updated commit title.
>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 1868f73..f9b922d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -655,18 +655,15 @@ static enum pipe vlv_find_free_pps(struct drm_i915_private *dev_priv)
> {
> struct drm_i915_private *dev_priv = to_i915(intel_dp_to_dev(intel_dp));
>
> + int backlight_controller = dev_priv->vbt.backlight.controller;
The patch looks right.
But I wonder if we could use somehow the already set panel->backlight.controller.
instead of duplicating this vbt association.
(set at bxt_setup_backlight)
> +
> lockdep_assert_held(&dev_priv->pps_mutex);
>
> /* We should never land here with regular DP ports */
> WARN_ON(!intel_dp_is_edp(intel_dp));
>
> - /*
> - * TODO: BXT has 2 PPS instances. The correct port->PPS instance
> - * mapping needs to be retrieved from VBT, for now just hard-code to
> - * use instance #0 always.
> - */
> if (!intel_dp->pps_reset)
> - return 0;
> + return backlight_controller;
>
> intel_dp->pps_reset = false;
>
> @@ -676,7 +673,7 @@ static enum pipe vlv_find_free_pps(struct drm_i915_private *dev_priv)
> */
> intel_dp_init_panel_power_sequencer_registers(intel_dp, false);
>
> - return 0;
> + return backlight_controller;
> }
>
> typedef bool (*vlv_pipe_check)(struct drm_i915_private *dev_priv,
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
