== Series Details == Series: drm/i915: Fix the frame buffer fence starvation URL : https://patchwork.freedesktop.org/series/38626/ State : warning == Summary == $ dim checkpatch origin/drm-tip f9fb22a0f4c9 drm/i915: Fix the frame buffer fence starvation -:29: CHECK: Alignment should match open parenthesis #29: FILE: drivers/gpu/drm/i915/intel_display.c:2072: +intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb, unsigned int rotation, + struct drm_plane *plane, enum pipe pipe) -:52: CHECK: Unnecessary parentheses around 'pipe == PIPE_A' #52: FILE: drivers/gpu/drm/i915/intel_display.c:2117: + if (INTEL_GEN(dev_priv) < 4 || (intel_fbc_can_enable(dev_priv) && + (pipe == PIPE_A) && intel_plane && + (intel_plane->id == PLANE_PRIMARY))) -:52: CHECK: Unnecessary parentheses around 'intel_plane->id == PLANE_PRIMARY' #52: FILE: drivers/gpu/drm/i915/intel_display.c:2117: + if (INTEL_GEN(dev_priv) < 4 || (intel_fbc_can_enable(dev_priv) && + (pipe == PIPE_A) && intel_plane && + (intel_plane->id == PLANE_PRIMARY))) -:53: CHECK: Alignment should match open parenthesis #53: FILE: drivers/gpu/drm/i915/intel_display.c:2118: + if (INTEL_GEN(dev_priv) < 4 || (intel_fbc_can_enable(dev_priv) && + (pipe == PIPE_A) && intel_plane && -:77: WARNING: 'consistancy' may be misspelled - perhaps 'consistency'? #77: FILE: drivers/gpu/drm/i915/intel_display.c:2140: + * it's not pinned to maintain the count consistancy. -:78: ERROR: trailing whitespace #78: FILE: drivers/gpu/drm/i915/intel_display.c:2141: +^I^I^I * This is because the count is unconditionally $ -:91: CHECK: Alignment should match open parenthesis #91: FILE: drivers/gpu/drm/i915/intel_display.c:2830: + intel_pin_and_fence_fb_obj(fb, primary->state->rotation, + primary, intel_crtc->pipe); -:102: WARNING: Missing a blank line after declarations #102: FILE: drivers/gpu/drm/i915/intel_display.c:12736: + struct intel_crtc *temp_crtc = to_intel_crtc(new_state->crtc); + vma = intel_pin_and_fence_fb_obj(fb, new_state->rotation, -:103: CHECK: Alignment should match open parenthesis #103: FILE: drivers/gpu/drm/i915/intel_display.c:12737: + vma = intel_pin_and_fence_fb_obj(fb, new_state->rotation, + plane, temp_crtc->pipe); -:113: WARNING: Missing a blank line after declarations #113: FILE: drivers/gpu/drm/i915/intel_display.c:13154: + struct intel_crtc *temp_crtc = to_intel_crtc(crtc); + vma = intel_pin_and_fence_fb_obj(fb, new_plane_state->rotation, -:114: CHECK: Alignment should match open parenthesis #114: FILE: drivers/gpu/drm/i915/intel_display.c:13155: + vma = intel_pin_and_fence_fb_obj(fb, new_plane_state->rotation, + plane, temp_crtc->pipe); total: 1 errors, 3 warnings, 7 checks, 121 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
