Quoting Chris Wilson (2018-02-20 13:25:21) > Convert the busy pwm from using a single calibration pass with a fixed > target into a self-correcting pwm that tries to adjust how long to sleep > on each pwm in order to converge at the target busy %%. > > Being self-correcting, it should fare better against the more variable > systems CI presents. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105157 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > --- > - assert_within_epsilon(busy_r, (double)target_busy_pct / 100.0, 0.15); > + assert_within_epsilon(busy_r, expected, 0.15); One thing that struck me here is that the tolerance end ups being very one-sided in that for low busy %% we are stricter than for high %%. We should add assert_within_epsilon(1 - busy_r, 1 - expected, 0.15); -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
