On 20/02/2018 10:57, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-02-20 10:47:42)From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> Commit fe49789fab97 ("drm/i915: Deconstruct execute fence") re-arranged the code and moved the i915_gem_request_execute tracepoint to before the global seqno is assigned to the request. We need to move the tracepoint a bit later so this information is once again available.Ok, iirc my thinking was just to have the tracing early to show the entry to i915_request_submit. If you are happy with having it at the end with the details filled in, so am I :)
We have trace_i915_gem_request_submit in the fence->submit_notify so I think it is OK.
Would it be better to move it to just after req->global_seqno is set, so before enable_signalling (it would be under the lock)?
I am just thinking that the spirit of the tracepoint was that global seqno should be known.
Regards, Tvrtko
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> Fixes: fe49789fab97 ("drm/i915: Deconstruct execute fence") Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxxReviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
