Quoting Sagar Arun Kamble (2018-02-17 08:51:44) > Earlier I had thought of calling ASSIGN_FW_DOMAINS_TABLE, > ASSIGN_*_MMIO_VFUNCS before intel_uncore_fw_domains_init > and use I915_READ here for reading the fuse. But that approach seems to > expose the vfuncs and forcewake table before fw domains > are initialized. Although we can get to know invalid access to > read/write accessors before fw_domains get initialized, current ordering > of fw_domains init followed by fw domain table/read/write vfuncs init > seems right. So using fw_domains_get/put as suggested above > should be the way. > > Chris, Tvrtko, Mika, do you agree? What's the complication with the fw_domains? Do the additional powerwell depend on the fused status of the extra engines? Does it matter if the fw_domain are prepped if they are never used? Imo, I would have placed the fused discovery in intel_engines_init_mmio() (where we do the setup and can take forcewake). Then adding something like intel_uncore_reinit_mmio() (which would just prune the uncore->fw_domains) after checking fused status with commentary doesn't seem that horrible. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
