Re: [PATCH v3] drm/i915: Clean up ancient doc comments for i915_ioc32.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jani Nikula (2018-02-15 14:00:34)
> On Thu, 15 Feb 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> > Quoting Chris Wilson (2018-02-14 16:07:20)
> >> As befitting a file dedicated to the mistakes of the past,
> >> 
> >> drivers/gpu/drm/i915/i915_ioc32.c:2: warning: Cannot understand  * \file i915_ioc32.c
> >>  on line 2 - I thought it was a doc line
> >> drivers/gpu/drm/i915/i915_ioc32.c:82: warning: Function parameter or member 'filp' not described in 'i915_compat_ioctl'
> >> drivers/gpu/drm/i915/i915_ioc32.c:82: warning: Function parameter or member 'cmd' not described in 'i915_compat_ioctl'
> >> drivers/gpu/drm/i915/i915_ioc32.c:82: warning: Function parameter or member 'arg' not described in 'i915_compat_ioctl'
> >> 
> >> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> >> ---
> >> Don't drop the fixes this time!
> >
> > Are we happy with this no-nonsense version?
> 
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Ta, so the only residual one is the quirky @channel.port to be resolved
:)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux