Quoting Rodrigo Vivi (2018-02-14 22:45:33)
> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
>
> > Rather than deriving the platform_mask from the
> > intel_device_static_info->platform at runtime, prefill it in the static
> > data.
> >
> > baseline.ko drivers/gpu/drm/i915/i915.ko
> > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-20 (-20)
> > Function old new delta
> > i915_driver_load 5027 5007 -20
> > Total: Before=1331200, After=1331180, chg -0.00%
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > ---
> > static const struct intel_device_info intel_cherryview_info = {
> > + PLATFORM(INTEL_CHERRYVIEW),
> > GEN(8),
>
> The order seems a bit strange... here it comes before the GEN
> and in other cases it comes after the GEN_FEATURES which includes GEN...
>
> probably we could make PLATFORM the very first thing on any case
> but up to you...
I was trying to have PLATFORM be the first non-inherited value in each
device_info. So the pattern I had in mind was
[GENx_FEATURES,]
PLATFORM(foo)
I was tempted to add feature defines for the atoms as well just so it
looked more consistent. Later on it was looking more like
static const PLATFORM_INFO(cherryview) = {
PLATFORM(INTEL_CHERRYVIEW),
...
};
where the repetition is more obvious (and easier to check)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
