Quoting Maarten Lankhorst (2018-02-08 16:50:08) > Op 08-02-18 om 17:16 schreef Chris Wilson: > > The unused-but-set warning enabled by W=1 catches out a lot of the > > atomic helper iterator macros and drown us in their noise (or trip over > > Werror and die). Path of least resistance is to ignore the warning. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/i915/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > > index 3bddd8a06806..f55cc028b2eb 100644 > > --- a/drivers/gpu/drm/i915/Makefile > > +++ b/drivers/gpu/drm/i915/Makefile > > @@ -17,6 +17,7 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) > > subdir-ccflags-y += $(call cc-disable-warning, type-limits) > > subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) > > subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) > > +subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable) > > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror > > > > # Fine grained warnings disable > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> And pushed with Joonas's r-b as well which didn't quite make the list. All but for an unused icelake device_info, we compile cleanly with W=1 on gcc-8. Lots more kerneldoc to cleanup though. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
