Re: [PATCH] drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Imre Deak (2018-02-08 11:23:31)
> FORCEWAKE_ACK is depricated by BSpec at least starting from BDW,
> referring to the multi-threaded version of it instead. Accessing
> FORCEWAKE_ACK triggers an unclaimed register access error - at
> least on GLK - see the Reference: below.
> 
> The correct registers to use would be FORCEWAKE_MT_ACK on IVB+ and
> FORCEWAKE_ACK_RENDER_GEN9 on SKL+ like it's done elsewhere in the
> driver.
> 
> The forcewake check itself is inconsistent and redundant, since there
> could be other forcewake requesters besides the kernel (being the
> multithreaded version of the register) and the kernel's per-domain
> forcewake counters are shown anyway at the end of the file. So let's
> just remove the check.
> 
> Suggested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=103337
> Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx>

Works for me,
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux