Quoting Jackie Li (2018-02-06 00:02:41) > +static inline bool __reg_locked(struct drm_i915_private *dev_priv, > + i915_reg_t reg) > +{ > + /* Explicitly cast the return value to bool. */ You already did by using bool. > + return !!(I915_READ(reg) & GUC_WOPCM_REG_LOCKED); i.e. this is equivalent as defined by the C spec to return I915_READ(reg) & GUC_WOPCM_REG_LOCKED; -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx