Quoting Rafael Antognolli (2018-02-05 23:33:30) > This workaround should prevent a bug that can be hit on a context > restore. To avoid the issue, we must emit a PIPE_CONTROL with CS stall > (0x7a000004 0x00100000 0x00000000 0x00000000) followed by 12DW's of > NOOP(0x0) in the indirect context batch buffer, to ensure the engine is > idle prior to programming 3DSTATE_SAMPLE_PATTERN. > > It's also not clear whether we should add those extra dwords because of > the workaround itself, or if that's just padding for the WA BB (and next > commands could come right after the PIPE_CONTROL). We keep them for now. > > References: HSD#1939868 > > v2: More descriptive changelog and comments. > v3: Explain that PIPE_CONTROL is actually 6 dwords, and that we advance > 10 more dwords because of that. > > Signed-off-by: Rafael Antognolli <rafael.antognolli@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks for the clear comment elucidating our doubt about what is actually required for the w/a. Pushed. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
