Re: [PATCH] drm/i915: Add some newlines to intel_engine_dump() headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> The headers should be on a separate line for consistency, so add the
> missing trailing newline in a few intel_engine_dump() callers.
>
> Reported-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/i915_gem.c        | 2 +-
>  drivers/gpu/drm/i915/intel_hangcheck.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 63308ec016a3..6a866810b529 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3644,7 +3644,7 @@ static int wait_for_engines(struct drm_i915_private *i915)
>  
>  			for_each_engine(engine, i915, id)
>  				intel_engine_dump(engine, &p,
> -						  "%s", engine->name);
> +						  "%s\n", engine->name);
>  		}
>  
>  		i915_gem_set_wedged(i915);
> diff --git a/drivers/gpu/drm/i915/intel_hangcheck.c b/drivers/gpu/drm/i915/intel_hangcheck.c
> index 348a4f7ffb67..42e45ae87393 100644
> --- a/drivers/gpu/drm/i915/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/intel_hangcheck.c
> @@ -359,7 +359,7 @@ static void hangcheck_accumulate_sample(struct intel_engine_cs *engine,
>  	case ENGINE_DEAD:
>  		if (drm_debug & DRM_UT_DRIVER) {
>  			struct drm_printer p = drm_debug_printer("hangcheck");
> -			intel_engine_dump(engine, &p, "%s", engine->name);
> +			intel_engine_dump(engine, &p, "%s\n", engine->name);
>  		}
>  		break;
>  
> -- 
> 2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux