Quoting Ville Syrjala (2018-02-02 20:42:31) > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Deprecate the silly I915_SET_COLORKEY_NONE flag. The obvious > way to disable colorkey is to just set flags to 0, which is > exactly what the intel ddx has been doing all along. I can confirm that I never realised the flag existed. Just not setting either the dst or src flags made sense to me. > Currently when userspace sets the flags to 0, we end up in a > funny state where colorkey is disabled, but various colorkey > vs. scaling checks still consider colorkey to be enabled, and > thus we don't allow plane scaling to kick in. > > In case there is some other userspace out there that actually > uses this flag (unlikely as this is an i915 specific uapi) > we'll keep on accepting it. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
