On Tue, 2018-01-09 at 10:38 +0100, Maarten Lankhorst wrote: > Op 08-01-18 om 20:59 schreef Pandiyan, Dhinakaran: > > On Thu, 2018-01-04 at 18:08 -0800, Rodrigo Vivi wrote: <snip> > >> I will probably have more comments later, but just doing a brain dump now > >> since I end up forgetting to write yesterday... > >> > >> The approach here in general is good and much better than that pre,post hooks. > >> But I just believe we can do this here in a more generic approach than deviating > >> the initial power well and domains. > > I would have liked a generic approach (for display_power_{get,put}), but > > I think this case is special enough that making it stand out is better. > Agreed, I can think of no other way myself without making the generic case too complicated. The whole runtime power management became way too complex for a special case. > I found out that DMC keeps the hardware out of DC5/6 when vblank interrupts are enabled. This simplified the solution a lot (https://patchwork.freedesktop.org/series/36435/) Thanks for your review on this series, would appreciate any feedback on the new one too :) -DK > ~Maarten > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx