Re: [PATCH] drm/i915/pmu: Initialise our dynamic sysfs attributes for use with lockdep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2018-01-11 14:12:38)
> You beat me to it, after I noticed the report on IRC and started 
> digging, just to find sysfs_attr_init, your fix arrived. Thanks!
> 
> It looks like a standard way of silencing lockdep for this case, 
> although I am not sure what exactly is the purpose of lock class keys in 
> sysfs attributes, and what this kind of defeat could also imply.
> 
> I planned to do it another loop, iterating the attr array, but I don't 
> see how it matters. It would be one static key versus the two. :?

It shouldn't as far as I'm aware. I'm conscious that each static attr
has its own lockclass, but dynamic users tend to have a shared
lockclass. It shouldn't matter unless we nest the sysfs operations?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux