Re: [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

[Rhys Kidd <rhyskidd@xxxxxxxxx>]

On 9 January 2018 at 05:11, Petri Latvala <petri.latvala@xxxxxxxxx> wrote:

Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
commit.") added a use of poll() to igt_kms.c, but that file only
includes poll.h when HAVE_UDEV is defined. Move the include outside
the UDEV conditional.

Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
Signed-off-by: Petri Latvala <petri.latvala@xxxxxxxxx>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I have also hit this issue, and spun up locally the equivalent patch fix, so also gets my:

Reviewed-by: Rhys Kidd <rhyskidd@xxxxxxxxx>

 

---
 lib/igt_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index ec3b7167..069752ec 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -40,8 +40,8 @@
 #endif
 #ifdef HAVE_UDEV
 #include <libudev.h>
-#include <poll.h>
 #endif
+#include <poll.h>
 #include <errno.h>
 #include <time.h>

--
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx