Re: [alsa-devel] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Does anyone know how to use Conexant CX20921 to develop our own application. I cannot find anywhere to download the software and manuals.

Thanks to all
J.D

-----Original Message-----
From: alsa-devel-bounces@xxxxxxxxxxxxxxxx [mailto:alsa-devel-bounces@xxxxxxxxxxxxxxxx] On Behalf Of Andy Shevchenko
Sent: 2017年12月20日 2:42
To: Joe Perches <joe@xxxxxxxxxxx>
Cc: linux-fbdev@xxxxxxxxxxxxxxx; David Airlie <airlied@xxxxxxxx>; Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Heiko Carstens <heiko.carstens@xxxxxxxxxx>; ALSA Development Mailing List <alsa-devel@xxxxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Peter Ujfalusi <peter.ujfalusi@xxxxxx>; linux-s390@xxxxxxxxxxxxxxx; Linux OMAP Mailing List <linux-omap@xxxxxxxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>; James Smart <james.smart@xxxxxxxxxxxx>; Cezary Jackiewicz <cezary.jackiewicz@xxxxxxxxx>; linux-serial@xxxxxxxxxxxxxxx; Jiri Slaby <jslaby@xxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; Zhang Rui <rui.zhang@xxxxxxxxx>; Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>; Mathias Nyman <mathias.nyman@xxxxxxxxx>; Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>; Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Eduardo Valentin <edubezval@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>; Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Felipe Balbi <balbi@xxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; USB <linux-usb@xxxxxxxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Luis R. Rodriguez <mcgrof@xxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxxxxx>; Martin Schwidefsky <schwidefsky@xxxxxxxxxx>; Jarkko Nikula <jarkko.nikula@xxxxxxxxxx>
Subject: Re: [alsa-devel] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
>   xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g; print;}'

>  drivers/platform/x86/compal-laptop.c | 18 +++++----------

> --- a/drivers/platform/x86/compal-laptop.c
> +++ b/drivers/platform/x86/compal-laptop.c
> @@ -679,18 +679,12 @@ static int bat_writeable_property(struct 
> power_supply *psy,
>  /* ============== */
>  /* Driver Globals */
>  /* ============== */
> -static DEVICE_ATTR(wake_up_pme,
> -               0644, wake_up_pme_show,         wake_up_pme_store);
> -static DEVICE_ATTR(wake_up_modem,
> -               0644, wake_up_modem_show,       wake_up_modem_store);
> -static DEVICE_ATTR(wake_up_lan,
> -               0644, wake_up_lan_show, wake_up_lan_store);
> -static DEVICE_ATTR(wake_up_wlan,
> -               0644, wake_up_wlan_show,        wake_up_wlan_store);
> -static DEVICE_ATTR(wake_up_key,
> -               0644, wake_up_key_show, wake_up_key_store);
> -static DEVICE_ATTR(wake_up_mouse,
> -               0644, wake_up_mouse_show,       wake_up_mouse_store);
> +static DEVICE_ATTR_RW(wake_up_pme);
> +static DEVICE_ATTR_RW(wake_up_modem); static 
> +DEVICE_ATTR_RW(wake_up_lan); static DEVICE_ATTR_RW(wake_up_wlan); 
> +static DEVICE_ATTR_RW(wake_up_key); static 
> +DEVICE_ATTR_RW(wake_up_mouse);

Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

for PDx86 bits.

Have to say that while it doesn't change the attributes here, it might require still to be revisited by security people, if they wish.

--
With Best Regards,
Andy Shevchenko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux