The discussion on how to fix the issues has been stagnant for a long time, see the Bugzilla below and: https://patchwork.freedesktop.org/patch/170429/ After only changing display cable the result of my machine went from always failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl flip-flop between pass and WARN and the shard-kbl always fail. This made me realize that the THRESHOLD_PER_CONNECTOR also needed to be updated, while previous discussion only touched the THRESHOLD_TOTAL. As discussed in provided links the motivation for this test is to discover big anomalies in edid timings, but with the current tight thresholds we are hitting the issues too often. V2: increased thresholds further after patchwork results. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047 Signed-off-by: Marta Lofstedt <marta.lofstedt@xxxxxxxxx> --- tests/kms_sysfs_edid_timing.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c index 12013881..53d96c1c 100644 --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -26,8 +26,8 @@ #include <fcntl.h> #include <sys/stat.h> -#define THRESHOLD_PER_CONNECTOR 10 -#define THRESHOLD_TOTAL 50 +#define THRESHOLD_PER_CONNECTOR 20 +#define THRESHOLD_TOTAL 150 #define CHECK_TIMES 15 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all " @@ -75,21 +75,21 @@ igt_simple_main close(fd); } - igt_debug("%s: mean.max %.2fns, %.2fus, %.2fms, " + igt_info("%s: mean.max %.2fns, %.2fus, %.2fms, " "mean.avg %.2fns, %.2fus, %.2fms\n", de->d_name, mean.max, mean.max / 1e3, mean.max / 1e6, mean.mean, mean.mean / 1e3, mean.mean / 1e6); if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) { - igt_warn("%s: probe time exceed 10ms, " + igt_warn("%s: probe time exceed %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_PER_CONNECTOR, mean.max / 1e6, mean.mean / 1e6); } igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6), - "%s: average probe time exceeded 50ms, " + "%s: average probe time exceeded %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_TOTAL, mean.max / 1e6, mean.mean / 1e6); } closedir(dirp); -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
