On Tue, 2017-12-12 at 14:56 -0800, Jackie Li wrote: > Hardware may have specific restrictions on GuC WOPCM partition > size versus HuC firmware size. With static WOPCM partitioning, > there's no way to adjust the GuC WOPCM partition size based on > the actual HuC firmware size, so that GuC/HuC loading failure > would occur even if there was enough WOPCM space for both > GuC and HuC firmware. WOPCM being a shared feature of the hardware, it should not go under intel_guc_ prefix. There should be a clear division of what is specific to GuC feature only and what is just a feature that happens to be used by GuC (and equally can be used by HuC too). Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx