Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 12, 2017 at 01:11:43PM +0100, Markus Heiser wrote:
> 
> > Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>:
> > 
> > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@xxxxxxxxxxx> wrote:
> > 
> >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
> >> section was removed from intel_guc_loader.c without a
> >> replacement.  So lets remove it from the Kernel-doc::
> >> 
> >>  .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> >>     :doc: GuC-specific firmware loader
> >> 
> >> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
> >> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
> >> renamed to intel_guc_fw_upload(). Since we get errors in the
> >> Sphinx build like:
> >> 
> >> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
> >> 
> >> Change the kernel-doc directive from intel_guc_loader.c to
> >> intel_guc_fw.c
> >> 
> >> Signed-off-by: Markus Heiser <markus.heiser@xxxxxxxxxxx>
> >> ---
> > 
> > Thanks for your patch, but similar fix is already merged here [1]
> > 
> > Michal
> > 
> > [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
> 
> 
> Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
> fix in that patch (doc section was removed in d9e2e0143c).  Can you or
> someone else from @intel fix this also?

I've rebased the patch from you to only take that remaining part.

Thanks for fixing this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux