On Tue, Apr 10, 2012 at 03:13:52PM -0700, Ben Widawsky wrote: > On Sat, Mar 31, 2012 at 11:22:01AM +0200, Daniel Vetter wrote: > > According to Bsepc, this should be set by default, but isn't. See vo1c.4 > > "Render Engine Command Streamer", Section 1.1.14.3 "3D_CHICKEN3" > > > > Bspec also says that we always need to set all mask bits. > I think this deserves to be a comment in the code itself. That really > made me say WTF when looking at the patch. Agreed, I'll add a comment to that effect. > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net> -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
