Quoting Joonas Lahtinen (2017-12-11 09:08:53)
> On Sat, 2017-12-09 at 10:44 +0000, Chris Wilson wrote:
> > Since the seqno information shown from i915_interrupt_info is just a
> > small subset of i915_engine_info, remove it.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>
> One comment below.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
>
> > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> > @@ -1690,6 +1690,11 @@ void intel_engine_dump(struct intel_engine_cs *engine,
> > if (i915_terminally_wedged(&engine->i915->gpu_error))
> > drm_printf(m, "*** WEDGED ***\n");
> >
> > + if (INTEL_GEN(dev_priv) >= 6) {
> > + drm_printf(m, " Interrupt mask: %08x\n",
> > + I915_READ_IMR(engine));
>
> Next printf is not capitalized.
Renamed it to RING_IMR (since we are already RING_foo for the other
registers) and moved it down next to the waitqueue printing.
Thanks for the review, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
