Matthew, On Thu, 7 Dec 2017, Matthew Auld wrote: Can you please add a version number to your patches? Having the same subject line five times is just annoying. > From: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > To give upcoming SKU BIOSes more flexibility in placing the Intel > graphics stolen memory, make all variables storing the placement or size > compatible with full 64 bit range. Also by exporting the stolen region > as a resource, we can then nuke the duplicated stolen discovery in i915. > > v2: export the stolen region as a resource > fix u16 << 16 (Chris) > v3: actually fix u16 << 16 And please move the version thing below the --- separator so it can be discarded by tools. It's not part of the changelog. > +struct resource intel_graphics_stolen_res = DEFINE_RES_MEM(0, 0); This is updated in __init so the variable should be marked __ro_after_init. Thanks, tglx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
