Quoting Chris Wilson (2017-12-07 23:56:25) > Since Michal introduced new errors other than -EIO during > i915_gem_init(), we need to actually unwind on the error path as we have > to abort the module load (and we expect to do so cleanly!). > > As we now teardown key state and then mark the driver as wedged (on > EIO), we have to be careful to not allow ourselves to resume and > unwedge, thus attempting to use the uninitialised driver. Hmm, I don't think this is sufficient just yet, e.g. execbuf should now report -EINVAL for the absent engine as opposed to -EIO we expect. Context allocation will still hit uninitialised idr etc. Back to the plan of having if (ret != -EIO) at each point, I guess. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
