Quoting Rodrigo Vivi (2017-12-07 23:04:13) > On Thu, Dec 07, 2017 at 10:24:34PM +0000, Chris Wilson wrote: > > Currently on every submission, we recalculate the ELSP register offset > > for the engine, after chasing the pointers to find the iomem base. Since > > this is fixed for the lifetime of the driver record the offset in the > > execlists struct. > > > > In practice the difference is negligible, it just happens to remove 27 > > bytes of eyesore pointer dancing from next to the hottest instruction > > (which is itself due to stalling for a cache miss) in perf profiles of > > the execlists_submission_tasklet(). > > > > v2: Trim off one more elsp local. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > > Reviewed-by: Michel Thierry <michel.thierry@xxxxxxxxx> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > would this be useful somehow on error state? Nope, write-only register. We do how what we think is in ELSP, i.e. what we last wrote to ELSP. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
