On Thu, Dec 07, 2017 at 04:59:36PM +0000, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-12-07 16:52:46) > > In some cases debugfs or sysfs may return errors that we > > want to check. Return -errno from helper functions to make > > asserts easier. > > > > v2: don't forget about EOF ret=0 (Chris) > > small re-write (Michal) > > > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Just tests/drv_hangman.c needs to fixed to use > igt_require(sysfs >= 0); Isn't the usual igt pattern that igt_foo never fails, and __igt_foo gives you the error code? But I guess we can do that later on in follow-ups. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
