Re: [PATCH i-g-t 3/6] meson: Install benchmarks to $libexec/intel-gpu-tools/benchmarks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 07, 2017 at 06:32:58PM +0200, Ville Syrjälä wrote:
> On Thu, Dec 07, 2017 at 03:40:28PM +0200, Petri Latvala wrote:
> > Signed-off-by: Petri Latvala <petri.latvala@xxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > ---
> >  benchmarks/meson.build | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/benchmarks/meson.build b/benchmarks/meson.build
> > index 4afd204f..26d65c4b 100644
> > --- a/benchmarks/meson.build
> > +++ b/benchmarks/meson.build
> > @@ -31,8 +31,12 @@ foreach prog : benchmark_progs
> >  	# FIXME meson doesn't like binaries with the same name
> >  	# meanwhile just suffix with _bench
> >  	executable(prog + '_bench', prog + '.c',
> > +		   install : true,
> > +		   install_dir : join_paths(get_option('libexecdir'), 'intel-gpu-tools', 'benchmarks'),
> 
> Could maybe define this benchmarksdir or something?

Yeah, I think extracting all the install dirs, and defining them all in
the top-level meson.build file would be good. Maybe as a follow-up.

And +1 on igt-gpu-tools, but that's perhaps also a different thing to
tackle, there's more places. Perhaps for igt 2.0 :-)
-Daniel

> 
> Either way
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> >  		   dependencies : test_deps)
> >  endforeach
> >  
> >  executable('gem_wsim_bench', 'gem_wsim.c',
> > +	   install : true,
> > +	   install_dir : join_paths(get_option('libexecdir'), 'intel-gpu-tools', 'benchmarks'),
> >  	   dependencies : test_deps + [ lib_igt_perf ])
> > -- 
> > 2.14.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel OTC

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux