Re: [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 07, 2017 at 04:52:04PM +0100, Noralf Trønnes wrote:
> 
> Den 07.12.2017 15.49, skrev Daniel Vetter:
> > We're spotting this very rarely in CI, but have no idea. Let's add
> > more debug info about what's going on here.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=102707
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
> 
> Acked-by: Noralf Trønnes <noralf@xxxxxxxxxxx>

Applied, thanks for taking a look!
-Daniel

> 
> >   drivers/gpu/drm/drm_mode_config.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> > index cc78b3d9e5e4..6ffe952142e6 100644
> > --- a/drivers/gpu/drm/drm_mode_config.c
> > +++ b/drivers/gpu/drm/drm_mode_config.c
> > @@ -469,6 +469,9 @@ void drm_mode_config_cleanup(struct drm_device *dev)
> >   	 */
> >   	WARN_ON(!list_empty(&dev->mode_config.fb_list));
> >   	list_for_each_entry_safe(fb, fbt, &dev->mode_config.fb_list, head) {
> > +		struct drm_printer p = drm_debug_printer("[leaked fb]");
> > +		drm_printf(&p, "framebuffer[%u]:\n", fb->base.id);
> > +		drm_framebuffer_print_info(&p, 1, fb);
> >   		drm_framebuffer_free(&fb->base.refcount);
> >   	}
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux