Re: [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/12/2017 15:02, Lionel Landwerlin wrote:
Hi,

After discussion with Chris, Joonas & Tvrtko, this series adds an
additional commit to link the render node back to the card through a
symlink. Making it obvious from an application using a render node to
know where to get the information it needs.

Important thing to mention as well is that it is trivial to get from the master drm fd to the sysfs root, via fstat and opendir /sys/dev/char/<major>:<minor>. With the addition of the card symlink to render nodes it is trivial for render node fd as well.

I am happy with this approach - it is extensible, flexible and avoids issues with ioctl versioning or whatnot. With one value per file it is trivial for userspace to access.

So for what I'm concerned, given how gputop would use all of this and so be the userspace, if everyone else is happy, I think we could do a detailed review and prehaps also think about including gputop in some distribution to make the case 100% straightforward.

Regards,

Tvrtko


Cheers,

Lionel Landwerlin (5):
   drm: add card symlink in render sysfs directory
   drm/i915: store all subslice masks
   drm/i915/debugfs: reuse max slice/subslices already stored in sseu
   drm/i915: expose engine availability through sysfs
   drm/i915: expose EU topology through sysfs

  drivers/gpu/drm/drm_drv.c                |  11 +
  drivers/gpu/drm/i915/i915_debugfs.c      |  50 ++--
  drivers/gpu/drm/i915/i915_drv.c          |   2 +-
  drivers/gpu/drm/i915/i915_drv.h          |  56 ++++-
  drivers/gpu/drm/i915/i915_sysfs.c        | 386 +++++++++++++++++++++++++++++++
  drivers/gpu/drm/i915/intel_device_info.c | 169 ++++++++++----
  drivers/gpu/drm/i915/intel_engine_cs.c   |  12 +
  drivers/gpu/drm/i915/intel_lrc.c         |   2 +-
  drivers/gpu/drm/i915/intel_ringbuffer.h  |   6 +-
  9 files changed, 617 insertions(+), 77 deletions(-)

--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux