Re: [RFC i-g-t 4/5] igt_dummyload: Add preemptible parameter to spin batch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Antonio Argenziano (2017-12-06 23:03:45)
>  void emit_recursive_batch(igt_spin_t *spin, int fd, igt_spin_opt_t opts);
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 9ec3b0f6..48d40e61 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -293,7 +293,8 @@ igt_hang_t igt_hang_ctx(int fd, igt_hang_opt_t opts)
>         if ((opts.flags & HANG_ALLOW_BAN) == 0)
>                 context_set_ban(fd, opts.ctx, 0);
>  
> -       emit_recursive_batch(&spin, fd, (igt_spin_opt_t){opts.ctx, opts.ring, 0});
> +       emit_recursive_batch(&spin, fd,
> +                       (igt_spin_opt_t){opts.ctx, opts.ring, 0, false});

The fun you can do with this is

	emit_recursive_batch(&spin, fd, (igt_spin_opt_t){
		.ctx = opts.ctx,
		.engine = opts.ring,
		/* anything unset is zero */
	});

which should make the changes much more palatable. Bonus points for
currying common patterns.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux